Skip to content

[My Store] Add support for storing site summary stats #8420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 15, 2022
Merged

[My Store] Add support for storing site summary stats #8420

merged 7 commits into from
Dec 15, 2022

Conversation

@rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Dec 15, 2022

Part of #8173

Description

This PR adds support for storing SiteSummaryStats in Core Data. This serves two purposes:

  1. It will allow us to retrieve summary stats from storage in the My Store dashboard, which is consistent with how other stats are synced and fetched there. (We could skip the storage layer but it would result in extra complexity or extraneous API requests.)
  2. Ultimately, it will allow us to use summary stats in the My Store dashboard, for consistency with the stats in Analytics Hub.

Changes:

  • Adds a new Core Data model 80.
  • Adds the SiteSummaryStats entity to Core Data, and supporting files.
  • Adds a migration unit test.

Changes to the Yosemite layer to support upserting stats in storage will come in another PR.

Testing instructions

This storage entity is not yet used in the app, so confirm unit tests pass.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added the feature: stats Related to stats, including Top Performers. label Dec 15, 2022
@rachelmcr rachelmcr added this to the 11.7 milestone Dec 15, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Dec 15, 2022 •
edited
Loading

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@rachelmcr rachelmcr mentioned this pull request Dec 15, 2022
Merged
1 task
@rachelmcr rachelmcr marked this pull request as ready for review December 15, 2022 14:19
@Ecarrion Ecarrion self-assigned this Dec 15, 2022
Ecarrion
Ecarrion approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@Ecarrion Ecarrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 15, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8420-d01b65f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@rachelmcr rachelmcr enabled auto-merge December 15, 2022 15:58
@rachelmcr rachelmcr merged commit 88bbc06 into trunk Dec 15, 2022
@rachelmcr rachelmcr deleted the issue/8173-sitesummarystats-storage branch December 15, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@Ecarrion Ecarrion Ecarrion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ecarrion Ecarrion

Labels

feature: stats Related to stats, including Top Performers.

Projects

None yet

Milestone

11.7

Development

Successfully merging this pull request may close these issues.

4 participants

@rachelmcr @wpmobilebot @Ecarrion